massdosage commented on pull request #1495:
URL: https://github.com/apache/iceberg/pull/1495#issuecomment-704810941


   Hey, I'm afraid I haven't had time to look at this but I did just try check 
out the `pvary:hivemetahook` branch and ran `./gradlew build' (using OpenJDK 11 
on Linux) and I get different test failures as mentioned above. Apache/master 
builds with no errors. FWIW here's a summary of the test failures from 
different runs - they all seem to be related to the row group filter:
   
   **org.apache.iceberg.data.TestMetricsRowGroupFilter:**
   ```
   org.apache.iceberg.exceptions.AlreadyExistsException: File already exists: 
/tmp/stats-row-group-filter-test.parquet
        at org.apache.iceberg.Files$LocalOutputFile.create(Files.java:58)
        at 
org.apache.iceberg.parquet.ParquetIO$ParquetOutputFile.create(ParquetIO.java:148)
        at 
org.apache.parquet.hadoop.ParquetFileWriter.<init>(ParquetFileWriter.java:295)
        at 
org.apache.parquet.hadoop.ParquetWriter.<init>(ParquetWriter.java:283)
        at 
org.apache.parquet.hadoop.ParquetWriter$Builder.build(ParquetWriter.java:564)
        at 
org.apache.iceberg.parquet.Parquet$WriteBuilder.build(Parquet.java:265)
        at 
org.apache.iceberg.data.TestMetricsRowGroupFilter.createParquetInputFile(TestMetricsRowGroupFilter.java:214)
   ```
   **org.apache.iceberg.parquet.TestDictionaryRowGroupFilter:**
   ```
   java.lang.RuntimeException: 
org.apache.iceberg.parquet.ParquetIO$ParquetInputFile@5b91de24 is not a Parquet 
file. expected magic number at tail [80, 65, 82, 49] but found [22, 0, 0, 0]
        at 
org.apache.parquet.hadoop.ParquetFileReader.readFooter(ParquetFileReader.java:531)
        at 
org.apache.parquet.hadoop.ParquetFileReader.<init>(ParquetFileReader.java:712)
        at 
org.apache.parquet.hadoop.ParquetFileReader.open(ParquetFileReader.java:597)
        at 
org.apache.iceberg.parquet.TestDictionaryRowGroupFilter.createInputFile(TestDictionaryRowGroupFilter.java:155)
   ```
   **TestDictionaryRowGroupFilter:** 15 failures, here are 3 of them:
   ```
   java.lang.AssertionError: Should skip: and(false, true)
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert.assertFalse(Assert.java:64)
        at 
org.apache.iceberg.parquet.TestDictionaryRowGroupFilter.testAnd(TestDictionaryRowGroupFilter.java:346)
   ```
   ```
   java.lang.AssertionError: Should not read: id below lower bound
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert.assertFalse(Assert.java:64)
        at 
org.apache.iceberg.parquet.TestDictionaryRowGroupFilter.testIntegerEq(TestDictionaryRowGroupFilter.java:453)
   ```
   ```
   java.lang.AssertionError: Should not read: id range above upper bound (85 < 
79)
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert.assertFalse(Assert.java:64)
        at 
org.apache.iceberg.parquet.TestDictionaryRowGroupFilter.testIntegerGt(TestDictionaryRowGroupFilter.java:415)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to