wgtmac commented on code in PR #132:
URL: https://github.com/apache/iceberg-cpp/pull/132#discussion_r2218122767
##########
src/iceberg/transform_function.cc:
##########
@@ -48,7 +48,27 @@ Result<ArrowArray> BucketTransform::Transform(const
ArrowArray& input) {
}
Result<std::shared_ptr<Type>> BucketTransform::ResultType() const {
- return NotImplemented("BucketTransform::result_type");
+ auto src_type = source_type();
+ if (!src_type) {
+ return NotSupported("null is not a valid input type for bucket transform");
Review Comment:
I agree. I think it makes sense to fix `Transform::Bind` by not directly
calling `std::make_unique<XYZTransform>(source_type)`. Instead we can use
`XYZTransform::Make(source_type)` and return error for invalid `source_type`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
