wgtmac commented on code in PR #149:
URL: https://github.com/apache/iceberg-cpp/pull/149#discussion_r2218316080
##########
cmake_modules/IcebergThirdpartyToolchain.cmake:
##########
@@ -98,10 +98,10 @@ function(resolve_arrow_dependency)
fetchcontent_declare(VendoredArrow
${FC_DECLARE_COMMON_OPTIONS}
- GIT_REPOSITORY https://github.com/apache/arrow.git
- GIT_TAG f12356adaaabea86638407e995e73215dbb58bb2
- #URL ${ARROW_SOURCE_URL}
- #URL_HASH
"SHA256=${ICEBERG_ARROW_BUILD_SHA256_CHECKSUM}"
+ #GIT_REPOSITORY https://github.com/apache/arrow.git
+ #GIT_TAG f12356adaaabea86638407e995e73215dbb58bb2
Review Comment:
```suggestion
```
Why not removing them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
