wypoon commented on a change in pull request #1508:
URL: https://github.com/apache/iceberg/pull/1508#discussion_r501464846
##########
File path:
spark3/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java
##########
@@ -62,7 +62,7 @@ public SparkTable getTable(StructType schema, Transform[]
partitioning, Map<Stri
Table icebergTable = getTableAndResolveHadoopConfiguration(options, conf);
// Build Spark table based on Iceberg table, and return it
- return new SparkTable(icebergTable, schema);
+ return new SparkTable(icebergTable, schema, options);
Review comment:
I extracted `snapshotId` and `asOfTimestamp` from `options` here if they
appear and pass the values to `SparkTable` in its constructor instead of having
`SparkTable` do that. I honestly think it's just half a dozen of one and six of
the other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
