dentiny commented on code in PR #1534:
URL: https://github.com/apache/iceberg-rust/pull/1534#discussion_r2225160582
##########
crates/iceberg/src/transaction/snapshot.rs:
##########
@@ -284,13 +279,26 @@ impl<'a> SnapshotProducer<'a> {
snapshot_produce_operation: &OP,
manifest_process: &MP,
) -> Result<Vec<ManifestFile>> {
- let added_manifest = self.write_added_manifest().await?;
+ // Assert current snapshot producer contains new content to add to new
snapshot.
+ if self.added_data_files.is_empty() &&
self.snapshot_properties.is_empty() {
Review Comment:
Sure! I created an issue to track:
https://github.com/apache/iceberg-rust/issues/1548
Also leave TODO items in the code along with the issue attached.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
