mxm commented on code in PR #13640:
URL: https://github.com/apache/iceberg/pull/13640#discussion_r2226082131
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestEvolveSchemaVisitor.java:
##########
@@ -463,7 +464,7 @@ public void testReplaceListWithPrimitive() {
assertThatThrownBy(
() ->
EvolveSchemaVisitor.visit(
- loadUpdateApi(currentSchema, 3), currentSchema,
targetSchema))
+ loadUpdateApi(currentSchema), currentSchema, targetSchema))
Review Comment:
That observation is correct, but it makes no difference for the correctness
of the test. The columns are matched by name, not by id. Before we even add the
column, where the `lastColumnId` would come into place for generating a new
field id, the test will already fail with the expected error message.
Generally, any value for lastColumnId >= the highest id (2 here) will work
(the ids must not overlap). Note that the SchemaUpdate code will increase the
provided value by 1 before using it as an id for a new field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
