rdblue commented on code in PR #13195:
URL: https://github.com/apache/iceberg/pull/13195#discussion_r2229799157
##########
api/src/main/java/org/apache/iceberg/expressions/VariantExpressionUtil.java:
##########
@@ -111,8 +113,19 @@ static <T> T castTo(VariantValue value, Type type) {
}
break;
- }
+ case TIMESTAMP:
+ case TIMESTAMP_NANO:
+ case TIME:
Review Comment:
I don't think that any conversion other than when types match should be
allowed. This is equivalent to `Literal#to(Type)` and we don't allow conversion
from date/time to int32 or int64 there. Why would this be necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
