pvary commented on code in PR #13426: URL: https://github.com/apache/iceberg/pull/13426#discussion_r2235286924
########## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/actions/BaseTableMaintenanceAction.java: ########## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink.actions; + +import java.util.List; +import java.util.UUID; +import java.util.function.Supplier; +import org.apache.flink.api.common.ExecutionConfig; +import org.apache.flink.streaming.api.datastream.DataStream; +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; +import org.apache.flink.streaming.api.graph.StreamGraphGenerator; +import org.apache.flink.util.CloseableIterator; +import org.apache.iceberg.flink.TableLoader; +import org.apache.iceberg.flink.maintenance.api.MaintenanceTaskBuilder; +import org.apache.iceberg.flink.maintenance.api.TableMaintenance; +import org.apache.iceberg.flink.maintenance.api.TaskResult; +import org.apache.iceberg.flink.maintenance.api.Trigger; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; + +abstract class BaseTableMaintenanceAction< + T extends BaseTableMaintenanceAction<T, B>, B extends MaintenanceTaskBuilder<?>> { + + private final StreamExecutionEnvironment env; + private final TableLoader tableLoader; + private static final int DEFAULT_PARALLELISM = ExecutionConfig.PARALLELISM_DEFAULT; + private final long triggerTimestamp; + private static final String DEFAULT_UID_SUFFIX = UUID.randomUUID().toString(); + private static final String DEFAULT_SLOT_SHARING_GROUP = + StreamGraphGenerator.DEFAULT_SLOT_SHARING_GROUP; + private static final int DEFAULT_TASK_INDEX = 0; + private final B builder; + + BaseTableMaintenanceAction( + StreamExecutionEnvironment env, TableLoader tableLoader, Supplier<B> builderSupplier) { + this(env, tableLoader, System.currentTimeMillis(), builderSupplier); + } + + BaseTableMaintenanceAction( + StreamExecutionEnvironment env, + TableLoader tableLoader, + long triggerTimestamp, + Supplier<B> builderSupplier) { + if (!tableLoader.isOpen()) { + tableLoader.open(); + } + + Preconditions.checkNotNull(tableLoader, "TableLoader should not be null"); + Preconditions.checkNotNull(builderSupplier, "BuilderSupplier should not be null"); + + this.env = env; + this.tableLoader = tableLoader; + this.triggerTimestamp = triggerTimestamp; + this.builder = builderSupplier.get(); + } + + /** + * Executes the maintenance task and returns the first task result. + * + * @return {@link TaskResult} from the execution, or null if no results were produced + * @throws Exception if any error occurs during task execution + */ + public TaskResult execute() throws Exception { + String tableName = tableLoader.loadTable().name(); + DataStream<TaskResult> resultDataStream = + builder.append( + createTriggerStream(), + tableName, + builder.maintenanceTaskName(), + DEFAULT_TASK_INDEX, + tableLoader(), + DEFAULT_UID_SUFFIX, + DEFAULT_SLOT_SHARING_GROUP, + DEFAULT_PARALLELISM); + try (CloseableIterator<TaskResult> iter = resultDataStream.executeAndCollect()) { Review Comment: 1. Would be nice to understand, but likely independent issue, and most probably Flink related. 2. This highlights, that there could be a quite serious cost if we decide to collect and return the results. So we might want to make collecting results optional. What do you think @Guosmilesmile? @mxm: Your thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
