rdblue commented on code in PR #13614: URL: https://github.com/apache/iceberg/pull/13614#discussion_r2237411675
########## core/src/main/java/org/apache/iceberg/RemoveSnapshots.java: ########## @@ -352,7 +352,7 @@ public void commit() { }); LOG.info("Committed snapshot changes"); - if (cleanExpiredFiles) { + if (cleanExpiredFiles && !base.snapshots().isEmpty()) { Review Comment: This seems odd. Shouldn't this happen automatically when `cleanExpiredSnapshots()` gathers the set of snapshots to clean? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org