nastra commented on code in PR #13700:
URL: https://github.com/apache/iceberg/pull/13700#discussion_r2250442901


##########
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/TestArrowReader.java:
##########
@@ -865,6 +896,8 @@ private List<GenericRecord> 
createConstantRecordsForDate(Schema schema, LocalDat
       rec.setField("uuid_nullable", uuid);
       rec.setField("decimal", new BigDecimal("14.20"));
       rec.setField("decimal_nullable", new BigDecimal("14.20"));
+      rec.setField("fixed", ("abcdefg").getBytes(StandardCharsets.UTF_8));

Review Comment:
   ```suggestion
         rec.setField("fixed", "abcdefg".getBytes(StandardCharsets.UTF_8));
   ```



##########
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/TestArrowReader.java:
##########
@@ -865,6 +896,8 @@ private List<GenericRecord> 
createConstantRecordsForDate(Schema schema, LocalDat
       rec.setField("uuid_nullable", uuid);
       rec.setField("decimal", new BigDecimal("14.20"));
       rec.setField("decimal_nullable", new BigDecimal("14.20"));
+      rec.setField("fixed", ("abcdefg").getBytes(StandardCharsets.UTF_8));
+      rec.setField("fixed_nullable", 
("abcdefg").getBytes(StandardCharsets.UTF_8));

Review Comment:
   ```suggestion
         rec.setField("fixed_nullable", 
"abcdefg".getBytes(StandardCharsets.UTF_8));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to