Guosmilesmile commented on code in PR #13728:
URL: https://github.com/apache/iceberg/pull/13728#discussion_r2251269772
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java:
##########
@@ -108,7 +108,8 @@ class DynamicCommitter implements
Committer<DynamicCommittable> {
this.maxContinuousEmptyCommitsMap = Maps.newHashMap();
this.continuousEmptyCheckpointsMap = Maps.newHashMap();
- this.workerPool = ThreadPools.newWorkerPool("iceberg-committer-pool-" +
sinkId, workerPoolSize);
+ this.workerPool =
+ ThreadPools.newFixedThreadPool("iceberg-committer-pool-" + sinkId,
workerPoolSize);
Review Comment:
You are right . I will add closing the pool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
