rdblue commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2254910767
########## core/src/main/java/org/apache/iceberg/data/PositionDeleteWriteBuilder.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.data; + +import java.io.IOException; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.Schema; +import org.apache.iceberg.deletes.PositionDelete; +import org.apache.iceberg.deletes.PositionDeleteWriter; + +/** + * A specialized builder for creating position-based delete file writers. + * + * <p>This builder extends the generic {@link ContentFileWriteBuilder} interface with functionality + * specific to creating {@link PositionDeleteWriter} instances. + * + * <p>The builder provides methods to configure the schema for the row data that might be included + * with the position deletes through {@link #rowSchema(Schema)}, enabling optional preservation of + * deleted record content. Review Comment: Do we need to include this in the refactor? I'm trying to think about ways to reduce scope. v3 and later require deletes to be stored as separate deletion vectors in Puffin files rather than allowing the old format. That means we don't need to do all of the work to preserve the existing functionality. For instance, I don't think that we have had any implementations actually produce Avro/Parquet position deletes with the deleted row embedded. We also won't write stats for row content because it is much faster to assign deletes to data files by referenced data file rather than running stats comparison. So I don't think that we need to carry forward the `rowSchema` functionality. We could consider not adding position deletes to this API at all, but I think that we want to still produce them when writing to v2 tables. I think the best choice is to support writing them, but with the simplest schema possible and not allow setting the row schema (which isn't used anyway). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
