rdblue commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2255185801
########## parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java: ########## @@ -155,42 +171,28 @@ public static WriteBuilder write(EncryptedOutputFile file) { } } + /** + * @deprecated Since 1.10.0, will be removed in 1.11.0. Use {@link + * FormatModelRegistry#writeBuilder(FileFormat, String, EncryptedOutputFile)} instead. + */ + @Deprecated Review Comment: I would strongly prefer that this class not be refactored and should instead implement the other interface. I don't think that all of these changes are necessary and replacing this class is too intrusive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org