wgtmac commented on code in PR #163:
URL: https://github.com/apache/iceberg-cpp/pull/163#discussion_r2257505182
##########
src/iceberg/catalog/in_memory_catalog.cc:
##########
@@ -441,7 +441,7 @@ Result<std::shared_ptr<Table>>
InMemoryCatalog::RegisterTable(
return LoadTable(identifier);
}
-std::unique_ptr<TableBuilder> InMemoryCatalog::BuildTable(
+std::unique_ptr<iceberg::Catalog::TableBuilder> InMemoryCatalog::BuildTable(
Review Comment:
```suggestion
std::unique_ptr<Catalog::TableBuilder> InMemoryCatalog::BuildTable(
```
##########
src/iceberg/catalog.h:
##########
@@ -233,6 +224,15 @@ class ICEBERG_EXPORT Catalog {
/// \return the Transaction to create the table
virtual std::unique_ptr<Transaction> StageCreate() = 0;
};
+
+ /// \brief Instantiate a builder to either create a table or start a
create/replace
+ /// transaction
+ ///
+ /// \param identifier a table identifier
+ /// \param schema a schema
+ /// \return the builder to create a table or start a create/replace
transaction
+ virtual std::unique_ptr<class TableBuilder> BuildTable(
Review Comment:
```suggestion
virtual std::unique_ptr<TableBuilder> BuildTable(
```
##########
src/iceberg/catalog/in_memory_catalog.h:
##########
@@ -90,8 +90,8 @@ class ICEBERG_EXPORT InMemoryCatalog
const TableIdentifier& identifier,
const std::string& metadata_file_location) override;
- std::unique_ptr<iceberg::TableBuilder> BuildTable(const TableIdentifier&
identifier,
- const Schema& schema)
const override;
+ std::unique_ptr<iceberg::Catalog::TableBuilder> BuildTable(
Review Comment:
```suggestion
std::unique_ptr<Catalog::TableBuilder> BuildTable(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
