nastra commented on code in PR #13694:
URL: https://github.com/apache/iceberg/pull/13694#discussion_r2259527710
##########
core/src/main/java/org/apache/iceberg/ManifestWriter.java:
##########
@@ -237,12 +237,13 @@ protected ManifestEntry<DataFile>
prepare(ManifestEntry<DataFile> entry) {
@Override
protected FileAppender<ManifestEntry<DataFile>> newAppender(
PartitionSpec spec, OutputFile file) {
- Schema manifestSchema = V4Metadata.entrySchema(spec.partitionType());
+ Schema manifestSchema = V4Metadata.entrySchema(spec);
try {
+ Schema schema = spec.schema();
return InternalData.write(FileFormat.AVRO, file)
.schema(manifestSchema)
.named("manifest_entry")
- .meta("schema", SchemaParser.toJson(spec.schema()))
+ .meta("schema", SchemaParser.toJson(schema))
Review Comment:
it actually looks like our ManifestReader depends on `schema` to exist in
https://github.com/apache/iceberg/blob/71629c12d2c609ae2473defdb5954e149f9f72e8/core/src/main/java/org/apache/iceberg/ManifestReader.java#L144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
