ForeverAngry commented on code in PR #2143: URL: https://github.com/apache/iceberg-python/pull/2143#discussion_r2264140937
########## pyiceberg/table/inspect.py: ########## Review Comment: Those changes i made were to fix these errors that exist on the main branch. I can revert it, but the ci/cd wont complete properly: ``` poetry run pre-commit run --all-files trim trailing whitespace.................................................Passed fix end of files.........................................................Passed debug statements (python)................................................Passed check yaml...............................................................Passed check python ast.........................................................Passed ruff (legacy alias)......................................................Passed ruff format..............................................................Passed mypy.....................................................................Failed - hook id: mypy - exit code: 1 tests/integration/test_inspect_table.py:831: error: "InspectTable" has no attribute "all_files"; maybe "_files"? [attr-defined] tests/integration/test_inspect_table.py:832: error: "InspectTable" has no attribute "all_data_files"; maybe "data_files"? [attr-defined] tests/integration/test_inspect_table.py:833: error: "InspectTable" has no attribute "all_delete_files"; maybe "delete_files"? [attr-defined] tests/integration/test_inspect_table.py:984: error: "InspectTable" has no attribute "all_files"; maybe "_files"? [attr-defined] tests/integration/test_inspect_table.py:985: error: "InspectTable" has no attribute "all_data_files"; maybe "data_files"? [attr-defined] tests/integration/test_inspect_table.py:986: error: "InspectTable" has no attribute "all_delete_files"; maybe "delete_files"? [attr-defined] tests/integration/test_inspect_table.py:1025: error: "InspectTable" has no attribute "all_files"; maybe "_files"? [attr-defined] tests/integration/test_inspect_table.py:1026: error: "InspectTable" has no attribute "all_data_files"; maybe "data_files"? [attr-defined] tests/integration/test_inspect_table.py:1027: error: "InspectTable" has no attribute "all_delete_files"; maybe "delete_files"? [attr-defined] Found 9 errors in 1 file (checked 158 source files) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
