DerGut opened a new pull request, #529:
URL: https://github.com/apache/iceberg-go/pull/529

   I ran a simple example without having setup my catalog URI correctly. This 
code snippet:
   ```go
   catalog, err := rest.NewCatalog(context.TODO(), "test", 
"http://localhost:8181";)
   if err != nil {
     slog.Error("Failed to create iceberg catalog", "error", err)
     return
   }
   ```
   errored with
   ```
   2025/08/10 20:50:39 ERROR Failed to create iceberg catalog error=": "
   ```
   
   ---
   
   Turns out, when the catalog is returning a non-200 response, we never check 
for decoding errors which is why we get the unhelpful `": "` error.
   
   In this PR, I've refactored the `func handleNon200` a little bit to 
accommodate this. The code is now instead returning something like `"decoding 
json response: EOF: REST error: server error"`. I have a corresponding 
[commit](https://github.com/DerGut/iceberg-go/commit/1c3d1b153afb61b6922f446f10b6960114f0323a)
 that shows this new behavior, it's not yet included in this PR because it's a 
bit clunky.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to