lliangyu-lin commented on code in PR #2266:
URL: https://github.com/apache/iceberg-python/pull/2266#discussion_r2267573310
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -405,7 +405,7 @@ def _compute_deletes(self) -> Tuple[List[ManifestFile],
List[ManifestEntry], boo
def _copy_with_new_status(entry: ManifestEntry, status:
ManifestEntryStatus) -> ManifestEntry:
return ManifestEntry.from_args(
status=status,
- snapshot_id=entry.snapshot_id,
+ snapshot_id=self.snapshot_id if status !=
ManifestEntryStatus.EXISTING else entry.snapshot_id,
Review Comment:
Yes, I agree the updated condition is more explicit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
