Fokko commented on code in PR #2323:
URL: https://github.com/apache/iceberg-python/pull/2323#discussion_r2270650923
##########
pyiceberg/io/fsspec.py:
##########
@@ -163,6 +164,9 @@ def _s3(properties: Properties) -> AbstractFileSystem:
if request_timeout := properties.get(S3_REQUEST_TIMEOUT):
config_kwargs["read_timeout"] = float(request_timeout)
+
+ if s3_anonymous := properties.get(S3_ANONYMOUS):
+ config_kwargs["anon"] = bool(s3_anonymous)
Review Comment:
For consistency, I would recommend `strtobool` in `pyiceberg/types.py`:
```suggestion
config_kwargs["anon"] = strtobool(s3_anonymous)
```
##########
pyiceberg/io/__init__.py:
##########
@@ -52,6 +52,7 @@
AWS_SESSION_TOKEN = "client.session-token"
AWS_ROLE_ARN = "client.role-arn"
AWS_ROLE_SESSION_NAME = "client.role-session-name"
+S3_ANONYMOUS = "s3.anonymous"
Review Comment:
https://s3fs.readthedocs.io/en/latest/#credentials
> If none of the credential methods are available, only anonymous access
will work, and `anon=True` must be passed to the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
