Fokko commented on code in PR #2269:
URL: https://github.com/apache/iceberg-python/pull/2269#discussion_r2271144679
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -118,6 +119,7 @@ def __init__(
commit_uuid: Optional[uuid.UUID] = None,
snapshot_properties: Dict[str, str] = EMPTY_DICT,
branch: str = MAIN_BRANCH,
+ stage_only: bool = False,
Review Comment:
Looking at it a bit more, I think that's the way forward.
https://github.com/apache/iceberg-python/blob/4b961f709625413abb4933476b593f64ae6f825d/pyiceberg/table/__init__.py#L434-L441
We would change that into:
```python
def update_snapshot(self, snapshot_properties: Dict[str, str] =
EMPTY_DICT, branch: Optional[str] = MAIN_BRANCH) -> UpdateSnapshot:
"""Create a new UpdateSnapshot to produce a new snapshot for the
table.
Returns:
A new UpdateSnapshot
"""
```
There are a couple more places where we need to change the default to
`MAIN_BRANCH`. Let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
