amogh-jahagirdar commented on code in PR #13004: URL: https://github.com/apache/iceberg/pull/13004#discussion_r2279157649
########## core/src/main/java/org/apache/iceberg/RESTFileScanTaskParser.java: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import com.fasterxml.jackson.core.JsonGenerator; +import com.fasterxml.jackson.databind.JsonNode; +import java.io.IOException; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.Set; +import org.apache.iceberg.expressions.Expression; +import org.apache.iceberg.expressions.ExpressionParser; +import org.apache.iceberg.expressions.ResidualEvaluator; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.util.JsonUtil; + +public class RESTFileScanTaskParser { Review Comment: Sorry for the back and forth, I was doing a final poke around this code locally and was thinking that we can probably organize things a tad better. If I understand right `RESTFileScanTaskParser` is defined here instead of in the `rest` module because we depend on ContentFileParser which is currently package private. I think the same applies for `TableScanResponseParser`. Ideally, both of these classes should exist in the rest module, since after all it is specific to REST. I think what we should do is make `ContentFileParser` public, which I don't think is a problem because our API already exposes ContentFile, ContentFileUtil so my rationale is why hide how we serialize/deserialize those if we already expose the concept? Making `ContentFileParser` public will then allow us to move both `RESTFileScanTaskParser` and `TableScanResponseParser` into the rest module where they belong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
