kinolaev commented on PR #13860: URL: https://github.com/apache/iceberg/pull/13860#issuecomment-3204455417
> allowing both Truncate(int width) and Truncate(long width) I don't think that it will simplify the PR. I actually started by adding Truncate(long width) alongside Truncate(int width). But at the end I found that all truncate(int) methods became useless proxies to corresponding truncate(long) methods with `(long) width` casting inside. As java converts int to long implicitly, nothing was changed when I deleted these truncate(int) methods. Except for the description in `.palantir/revapi.yml` of course) So from my point of view we don't need Truncate(int width), but I can do another PR for a comprehensive comparison and we can choose the best implementation. Would you like me to do it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
