liurenjie1024 commented on code in PR #1612:
URL: https://github.com/apache/iceberg-rust/pull/1612#discussion_r2287659307
##########
crates/catalog/hms/src/catalog.rs:
##########
@@ -51,7 +146,8 @@ pub enum HmsThriftTransport {
/// Hive metastore Catalog configuration.
#[derive(Debug, TypedBuilder)]
-pub struct HmsCatalogConfig {
+pub(crate) struct HmsCatalogConfig {
Review Comment:
Please remove the `TypedBuilder`, it's not needed.
##########
crates/catalog/hms/src/catalog.rs:
##########
@@ -29,15 +29,110 @@ use iceberg::io::FileIO;
use iceberg::spec::{TableMetadata, TableMetadataBuilder};
use iceberg::table::Table;
use iceberg::{
- Catalog, Error, ErrorKind, MetadataLocation, Namespace, NamespaceIdent,
Result, TableCommit,
- TableCreation, TableIdent,
+ Catalog, CatalogBuilder, Error, ErrorKind, MetadataLocation, Namespace,
NamespaceIdent, Result,
+ TableCommit, TableCreation, TableIdent,
};
use typed_builder::TypedBuilder;
use volo_thrift::MaybeException;
use super::utils::*;
use crate::error::{from_io_error, from_thrift_error, from_thrift_exception};
+/// HMS catalog address
+pub const HMS_CATALOG_PROP_ADDRESS: &str = "address";
Review Comment:
```suggestion
pub const HMS_CATALOG_PROP_URI: &str = "uri";
```
Making this a uri to be more consistent with others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
