hsiang-c commented on code in PR #13434:
URL: https://github.com/apache/iceberg/pull/13434#discussion_r2288794770
##########
core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java:
##########
@@ -91,6 +96,16 @@ public Table registerTable(TableIdentifier identifier,
String metadataFileLocati
return new BaseTable(ops, fullTableName(name(), identifier),
metricsReporter());
}
+ protected void targetNamespaceExists(TableIdentifier identifier) {
Review Comment:
@nastra Thank you for the feedback and I agree w/ you.
> That's also why we introduced the requiresNamespaceCreate() flag in the
tests.
I like this idea when I am working on the test.
How about we make the `requiresNamespaceCreate()` a default method (return
false by default) in `SupportsNamespaces`?
Doing so:
1. Makes the requirement explicitly per implementation, i.e. promoting this
semantics from `src/test` to `src/main`.
2. Skips `targetNamespaceExists` check if the catalog implementation doesn't
require it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
