CTTY commented on code in PR #1625:
URL: https://github.com/apache/iceberg-rust/pull/1625#discussion_r2314814750
##########
crates/iceberg/src/writer/file_writer/location_generator.rs:
##########
@@ -136,8 +159,17 @@ pub(crate) mod test {
}
impl LocationGenerator for MockLocationGenerator {
- fn generate_location(&self, file_name: &str) -> String {
- format!("{}/{}", self.root, file_name)
+ fn generate_location(&self, partition: Option<&PartitionKey>,
file_name: &str) -> String {
Review Comment:
It turns out there are 20+ usages of Mock loc gen across the code base, and
I think it may be better to have a separate PR, I can work on it after this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
