nandorKollar commented on PR #13949: URL: https://github.com/apache/iceberg/pull/13949#issuecomment-3245150514
> @nandorKollar > > > I think there's an inevitable increase in memory footprint... > > I agree there’s additional memory usage. This change was exploratory, and the performance gain appears minimal relative to the added complexity. I propose reverting to the original allocation behavior, only keep the precondition check in [5f8d80b](https://github.com/apache/iceberg/commit/5f8d80b4d1f72371951e917bd517d686ab2861d2) Meanwhile I figured out that probably the memory overhead is negligible, as we keep these vectors open for the pages. Nevertheless, I agree that it increases the complexity, and in case the performance benefit is minimal, like you mentioned, then I also vote for keeping only the precondition check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
