joellubi commented on code in PR #552:
URL: https://github.com/apache/iceberg-go/pull/552#discussion_r2316618652
##########
catalog/rest/options.go:
##########
@@ -108,6 +109,12 @@ func WithAdditionalProps(props iceberg.Properties) Option {
}
}
+func WithCustomTransport(transport http.RoundTripper) Option {
Review Comment:
I added a docstring calling out the potential for this option to shadow
`WithTLSConfig`, but also added a check to specifically report that condition
and a test for it. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
