nullccxsy commented on code in PR #207:
URL: https://github.com/apache/iceberg-cpp/pull/207#discussion_r2326682378
##########
src/iceberg/schema.cc:
##########
@@ -257,4 +257,260 @@ void NameToIdVisitor::Finish() {
}
}
+class PruneColumnVisitor {
+ public:
+ explicit PruneColumnVisitor(const std::unordered_set<int32_t>& selected_ids,
+ bool select_full_types = false);
+ Status Visit(const ListType& type, std::shared_ptr<const Type>& result);
+ Status Visit(const MapType& type, std::shared_ptr<const Type>& result);
+ Status Visit(const StructType& type, std::shared_ptr<const Type>& result);
+ Status Visit(const PrimitiveType& type, std::shared_ptr<const Type>& result);
+ Status ProjectList(const SchemaField& element,
Review Comment:
Yes, `ProjectSelectedStruct ` is need here to make `child_result` not null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
