JingsongLi commented on pull request #1625:
URL: https://github.com/apache/iceberg/pull/1625#issuecomment-711494281


   I see, My previous idea is that it is within the scope of `RowData`. For 
example, for Spark, `ColumnarBatch` also follows the interface of 
`InternalRow`. But I am OK to make it more generic.
   
   Can you move this `convertConstant` to a new util class, like 
`org.apache.iceberg.flink.data.RowDataUtils`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to