amogh-jahagirdar commented on code in PR #14035:
URL: https://github.com/apache/iceberg/pull/14035#discussion_r2335142176
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -425,10 +429,23 @@ public <T extends RESTResponse> T handleRequest(
case LOAD_TABLE:
{
- LoadTableResponse resp = CatalogHandlers.loadTable(catalog,
tableIdentFromPathVars(vars));
+ TableIdentifier ident = tableIdentFromPathVars(vars);
- responseHeaders.accept(
- ImmutableMap.of(HttpHeaders.ETAG,
ETagProvider.of(resp.metadataLocation())));
+ LoadTableResponse resp = CatalogHandlers.loadTable(catalog, ident);
Review Comment:
Nit: can we use the full word `response` to better fit the style of the
project
##########
api/src/main/java/org/apache/iceberg/exceptions/NotModifiedException.java:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.exceptions;
+
+import com.google.errorprone.annotations.FormatMethod;
+
+/** Exception to indicate that resource is unchanged. */
+public class NotModifiedException extends RESTException {
Review Comment:
Have we considered putting the handling of 304 in the actual HTTP client
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/rest/HTTPClient.java#L326
similar to 204 handling? I think the argument there is we should just be able
to return null for the table response and then we don't really need to treat
this like an "error" case.
##########
api/src/main/java/org/apache/iceberg/exceptions/NotModifiedException.java:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.exceptions;
+
+import com.google.errorprone.annotations.FormatMethod;
+
+/** Exception to indicate that resource is unchanged. */
+public class NotModifiedException extends RESTException {
Review Comment:
I'm not sure I agree with clients handling the 304 from the server as an
error and throwing . I see how it's convenient though in the current
implementation since then it's just a try/catch and also in this case there's
no real body to work with in the response. In my mind, it's fundamentally not
an error so modeling it as an exception doesn't seem right.
I'll need to think more if there's a better alternative though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
