wgtmac commented on code in PR #223:
URL: https://github.com/apache/iceberg-cpp/pull/223#discussion_r2338307434
##########
dev/release/release.sh:
##########
@@ -63,13 +63,6 @@ svn \
svn co "${dist_url}/${release_id}"
pushd "${release_id}"
-echo "Renaming artifacts to their final release names..."
Review Comment:
We don't need this hack any more. Now artifact names do not have `-rcN`
suffix. @HeartLinked
cc @liurenjie1024
##########
dev/release/verify_rc.sh:
##########
@@ -118,9 +118,11 @@ test_source_distribution() {
# Configure build
cmake -S . -B build \
+ -DCMAKE_CXX_FLAGS="-Wno-deprecated-declarations" \
Review Comment:
I have added `--compile-no-warning-as-error` below and this one is also
required. @lidavidm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
