alessandro-nori opened a new pull request, #562:
URL: https://github.com/apache/iceberg-go/pull/562

   ## Summary
   
   - Replace hardcoded bucketName field with injectable KeyExtractor function 
in blobFileIO
   - Add specialized adlsKeyExtractor for Azure schemes using regex pattern 
from Java implementation  
   - Maintain backward compatibility while improving flexibility and error 
handling
   - Add comprehensive unit tests for both key extractors
   
   ## Changes
   
   - **blob.go**: Replaced bucketName with KeyExtractor function parameter
   - **azure.go**: Added adlsKeyExtractor with regex pattern matching Azure URI 
format
   - **io.go**: Updated scheme routing to use appropriate key extractors
   - **Tests**: Added unit tests covering various URI formats and edge cases
   
   ## Test Plan
   
   - [x] All existing tests pass
   - [x] New unit tests for defaultKeyExtractor and adlsKeyExtractor
   - [x] Linting passes with 0 issues
   - [x] Build completes successfully
   
   Fixes #561


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to