nastra commented on code in PR #14113:
URL: https://github.com/apache/iceberg/pull/14113#discussion_r2364034397
##########
bigquery/src/test/java/org/apache/iceberg/gcp/bigquery/TestBigQueryCatalog.java:
##########
@@ -171,4 +177,30 @@ public void renameTableNamespaceMissing() {
public void testRenameTableMissingSourceTable() {
super.testRenameTableMissingSourceTable();
}
+
+ @Test
+ public void testIsValidIdentifierWithValidSingleLevelNamespace() {
+ TableIdentifier validIdentifier = TableIdentifier.of("dataset1", "table1");
+ assertThat(catalog.isValidIdentifier(validIdentifier)).isTrue();
+ }
+
+ @Test
+ public void testIsValidIdentifierWithInvalidMultiLevelNamespace() {
+ TableIdentifier invalidIdentifier =
Review Comment:
nit: all of these can be inlined
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
