kbendick commented on issue #1628: URL: https://github.com/apache/iceberg/issues/1628#issuecomment-713133254
Thanks for letting me know @jerryshao. For your own update, a lot of things in that PR seem to have been somewhat merged in. Possibly try forking off of your current branch and merging in master to check the diff. A number of files might go away. For example, if you check this PR (which I thought I linked to this issue but somehow the link didn't show), you'll see that the `Microbatches` class that's in your PR exists in some form: https://github.com/apache/iceberg/pull/1627/files I just updated one javadoc comment and then added some tests to verify behavior. So I would think that possibly seeing if you can take your old PR (and the changes that you mentioned if you should like), place them in a new branch based off of the latest master, and see if the overall PR gets smaller. My guess is that it might still need to be broken up into one or two refactor PRs, but I think the overall size of it will be much smaller. Please let me know if I can be of help in some way and I'll see what I can do (time at work permitting). Thanks for you reply! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
