pvary commented on code in PR #13963: URL: https://github.com/apache/iceberg/pull/13963#discussion_r2343879909
########## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecordProcessor.java: ########## @@ -37,17 +39,21 @@ class DynamicRecordProcessor<T> extends ProcessFunction<T, DynamicRecordInternal @VisibleForTesting static final String DYNAMIC_TABLE_UPDATE_STREAM = "dynamic-table-update-stream"; + @VisibleForTesting static final String ERROR_STREAM = "error-stream"; Review Comment: This is not only visible for testing. This is reused in the DynamicTableUpdateOperator, so we should remove the annotation. Also maybe move this to the DynamicIcebergSink class? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
