stevenzwu commented on code in PR #12298:
URL: https://github.com/apache/iceberg/pull/12298#discussion_r2377282388
##########
core/src/main/java/org/apache/iceberg/deletes/PositionDeleteWriter.java:
##########
@@ -66,12 +66,38 @@ public PositionDeleteWriter(
PartitionSpec spec,
StructLike partition,
EncryptionKeyMetadata keyMetadata) {
+ this(
+ appender,
+ format,
+ location,
+ spec,
+ partition,
+ keyMetadata != null ? keyMetadata.buffer() : null);
+ }
+
+ public PositionDeleteWriter(PositionDeleteWriter<T> wrapped) {
Review Comment:
similarly, this refactoring doesn't seem required here. also doesn't save
lines of code.
##########
core/src/main/java/org/apache/iceberg/io/DataWriter.java:
##########
@@ -57,12 +57,41 @@ public DataWriter(
StructLike partition,
EncryptionKeyMetadata keyMetadata,
SortOrder sortOrder) {
+ this(
+ appender,
+ format,
+ location,
+ spec,
+ partition,
+ keyMetadata != null ? keyMetadata.buffer() : null,
+ sortOrder);
+ }
+
+ public DataWriter(DataWriter<T> wrapped) {
Review Comment:
similar comment for non-required refactoring
##########
core/src/main/java/org/apache/iceberg/data/DeleteLoader.java:
##########
Review Comment:
why is this class moved to `core` module? doesn't seem to be used in core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
