twuebi commented on code in PR #585:
URL: https://github.com/apache/iceberg-go/pull/585#discussion_r2413758618


##########
table/metadata.go:
##########
@@ -743,6 +753,11 @@ func (b *MetadataBuilder) SetLastUpdatedMS() 
*MetadataBuilder {
        return b
 }
 
+func (b *MetadataBuilder) SetNextRowID(nextRowID int64) *MetadataBuilder {
+       b.nextRowID = &nextRowID
+       return b
+}

Review Comment:
   looking at iceberg-java, there's only a write to `nextRowId` in 
`Builder::addSnapshot` which does:
   
   ```java
   this.nextRowId += snapshot.addedRows();
   ```
   
   other assignments are either carryover from base metadata to builder or 
initial assignment to initial row id.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to