wgtmac commented on code in PR #253:
URL: https://github.com/apache/iceberg-cpp/pull/253#discussion_r2415606941
##########
src/iceberg/expression/literal.h:
##########
@@ -55,8 +56,9 @@ class ICEBERG_EXPORT Literal {
float, // for float
double, // for double
std::string, // for string
+ Uuid, // for uuid
std::vector<uint8_t>, // for binary, fixed
- std::array<uint8_t, 16>, // for uuid and decimal
+ std::array<uint8_t, 16>, // for decimal
Review Comment:
Do you want a separate PR for changing the decimal type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
