okumin commented on code in PR #14671:
URL: https://github.com/apache/iceberg/pull/14671#discussion_r2554891729
##########
open-api/src/testFixtures/java/org/apache/iceberg/rest/RCKUtils.java:
##########
@@ -37,7 +37,24 @@ class RCKUtils {
static final String RCK_LOCAL = "rck.local";
static final String RCK_PURGE_TEST_NAMESPACES = "rck.purge-test-namespaces";
- static final List<Namespace> TEST_NAMESPACES = List.of(Namespace.of("ns"),
Namespace.of("newdb"));
+ static final List<Namespace> TEST_NAMESPACES =
+ List.of(
+ Namespace.empty(),
+ Namespace.of("a"),
+ Namespace.of("ns"),
+ Namespace.of("ns1"),
+ Namespace.of("ns2"),
+ Namespace.of("ns_1"),
+ Namespace.of("ns_2"),
+ Namespace.of("newdb"),
+ Namespace.of("newdb_1"),
+ Namespace.of("newdb_2"),
+ Namespace.of("other_ns"),
+ Namespace.of("parent"),
+ Namespace.of("parent", "child1"),
+ Namespace.of("parent", "child2"),
+ Namespace.of("new/db"),
+ Namespace.of("new.db"));
Review Comment:
Some REST catalogs don't support empty/nested/slashed/dotted namespaces, and
`RESTCatalog#namespaceExists` might throw an exception. In that case, [this
filter](https://github.com/apache/iceberg/blob/8b55ac834015ce664f879ecfe1e80a941a994420/open-api/src/testFixtures/java/org/apache/iceberg/rest/RCKUtils.java#L132)
also throws an exception.
If we can assume a REST catalog returns `false`, this list is probably not
harmful. [HiveCatalog behaves like
that](https://github.com/apache/iceberg/blob/8b55ac834015ce664f879ecfe1e80a941a994420/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java#L646-L648),
and I expect a REST catalog to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
