slfan1989 commented on code in PR #14941:
URL: https://github.com/apache/iceberg/pull/14941#discussion_r2658912659
##########
build.gradle:
##########
@@ -1230,3 +1233,19 @@ project(':iceberg-bom') {
// Needed to get the "faked" Scala artifacts into the bom
javaPlatform { allowDependencies() }
}
+
+subprojects {
+ if (project.name.startsWith('iceberg-spark') ||
+ project.name.startsWith('iceberg-flink') ||
+ project.name.startsWith('iceberg-delta-lake') ||
+ project.name.startsWith('iceberg-kafka-connect')) {
Review Comment:
@huaxingao Thank you very much for reviewing the code and for the helpful
suggestions.
From my perspective, I also lean toward scoping this rule to the relevant
components (e.g., Spark / Flink / Kafka Connect), since the current
org.lz4:lz4-java vulnerability is primarily introduced via transitive
dependencies in the Spark/Flink/Kafka dependency trees. This would help reduce
the impact on other unrelated modules.
From my side: +1 to scoping the rule to Spark / Flink / Kafka Connect.
@singhpk234 Can you agree with this improvement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
