pvary commented on code in PR #14952: URL: https://github.com/apache/iceberg/pull/14952#discussion_r2661500131
########## flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergSink.java: ########## @@ -162,7 +163,7 @@ public class IcebergSink private final transient FlinkMaintenanceConfig flinkMaintenanceConfig; private final Table table; - private final Set<String> equalityFieldColumns = null; + private final Set<String> equalityFieldColumns; Review Comment: Could we leave a comment that this should only be used for logging, and `equalityFieldIds` should be used instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
