pvary commented on code in PR #14810:
URL: https://github.com/apache/iceberg/pull/14810#discussion_r2661544342
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java:
##########
@@ -126,9 +125,14 @@ public void
commit(Collection<CommitRequest<DynamicCommittable>> commitRequests)
return;
}
- // For every table and every checkpoint, we store the list of
to-be-committed
- // DynamicCommittable.
- // There may be DynamicCommittable from previous checkpoints which have
not been committed yet.
+ /*
+ Each (table, branch, checkpoint) triplet must have only one commit
request.
+ There may be commit requests from previous checkpoints which have not
been committed yet.
+
+ We currently keep a List of commit requests per checkpoint instead of a
single CommitRequest<DynamicCommittable>
+ to process the Flink state from previous releases, which had multiple
commit requests due to a bug in the upstream
+ DynamicWriteResultAggregator. We should replace this with a single
commit request in the next major release.
Review Comment:
Please help me refresh where we are related to this comment.
A few things:
- 1.10.1 is released, but (because of my questions) this PR did not make it
there
- 1.11.0 is the next planned release
- If I understand correctly, since the Dynamic Sink is experimental, we can
be a bit more lax with the state restore expectations
@aiborodin, @mxm, @Guosmilesmile: What do you think about simplifying the
code and forcing the users to upgrade `stop-with-savepoint` and restore with
`allowNonRestoredState`, and documenting it in the release notes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
