ferhatelmas commented on issue #665: URL: https://github.com/apache/iceberg-go/issues/665#issuecomment-3712188948
I can give a hand for the implementation but this needs a clarification. Exposing a page size flag won't change anything in usage externally because * https://github.com/apache/iceberg-go/pull/306 adds pagination for tables and cli iterates all over them correctly. Setting a page internally can tweak number of HTTP requests but end result will be same. * same feature is missing for namespaces in the catalog so not specific to CLI. Even if it's set in context, it won't be used. Is the idea to implement similar to tables and return an iterator (breaking change) or iterate internally and keep the interface same (as done in Glue catalog)? Relatedly, this issue talks about REST catalog but Glue catalog page size isn't configurable either. Should it be fixed at the same time (pass via context as in REST) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
