kevinjqliu opened a new pull request, #2885:
URL: https://github.com/apache/iceberg-python/pull/2885
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Add the `--build` flag to `docker compose up`. This will trigger docker to
rebuild if the docker-compose file or the Dockerfile is changed.
This is useful when we need to change the `ICEBERG_VERSION` in
[dev/spark/Dockerfile](https://github.com/apache/iceberg-python/blob/dea80784a5f9d6936a605c7ccb0f3f8d4ba30d9d/dev/spark/Dockerfile#L21).
Previously, `make integration` will not pick up the new `ICEBERG_VERSION`
change. It will only be picked up by rebuilding the image explicitly with `make
test-integration-rebuild`.
With this PR, the `ICEBERG_VERSION` will be picked up automatically. The new
Iceberg jar will be downloaded and the rest of the docker artifacts will be
cached.
## Are these changes tested?
Yes, manually using `ICEBERG_VERSION=1.10.1`
## Are there any user-facing changes?
No
<!-- In the case of user-facing changes, please add the changelog label. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
