aditya-subrahmanyan opened a new pull request, #1998: URL: https://github.com/apache/iceberg-rust/pull/1998
## Which issue does this PR close? - Closes #1981. ## What changes are included in this PR? The [spec](https://iceberg.apache.org/spec/#appendix-b-32-bit-hash-requirements) states that: >"Decimal values are hashed using the minimum number of bytes required to hold the unscaled value as a two's complement big-endian". Prior to this fix, we would incorrectly consume leading `0xFF` bytes and hash them. Now, we only consume the bytes starting with the one that is used to preserve the sign, and everything that follows it. ## Are these changes tested? Added unit tests for original scenario mentioned in the issue, as well as some additional cases -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
