pratik0316 commented on code in PR #2002:
URL: https://github.com/apache/iceberg-rust/pull/2002#discussion_r2665383540
##########
crates/integrations/datafusion/src/physical_plan/write.rs:
##########
@@ -230,24 +231,7 @@ impl ExecutionPlan for IcebergWriteExec {
self.table.metadata().current_schema().clone(),
FieldMatchMode::Name,
);
- let target_file_size = match self
- .table
- .metadata()
- .properties()
- .get(TableProperties::PROPERTY_WRITE_TARGET_FILE_SIZE_BYTES)
- {
- Some(value_str) => value_str
- .parse::<usize>()
- .map_err(|e| {
- Error::new(
- ErrorKind::DataInvalid,
- "Invalid value for write.target-file-size-bytes",
- )
- .with_source(e)
- })
- .map_err(to_datafusion_error)?,
- None =>
TableProperties::PROPERTY_WRITE_TARGET_FILE_SIZE_BYTES_DEFAULT,
- };
+ let target_file_size = table_props.write_target_file_size_bytes;
Review Comment:
in this change if the prop is **None** are we doing a fallback to the
defaults?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
