singhpk234 commented on code in PR #14886:
URL: https://github.com/apache/iceberg/pull/14886#discussion_r2665721524
##########
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##########
@@ -142,6 +142,11 @@ default DeleteOrphanFiles equalAuthorities(Map<String,
String> newEqualAuthoriti
interface Result {
/** Returns locations of orphan files. */
Iterable<String> orphanFileLocations();
+
+ /** Returns the total number of orphan files. */
+ default long orphanFilesCount() {
+ return 0;
Review Comment:
I was comming from other case pov what if we deleted the orphan file count
and we said 0 were deleted since we didn't override it ?
may be then throwing unsupported exception is the right thing to do ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
