kevinjqliu commented on code in PR #2528: URL: https://github.com/apache/iceberg-python/pull/2528#discussion_r2666108463
########## dev/.rat-excludes: ########## @@ -5,3 +5,4 @@ build .gitignore uv.lock mkdocs/* +notebooks/* Review Comment: yea agreed. i double check the artifacts, the new `notebooks/` dir is not included. Similar to how the `mkdocs/` dir is not included. Feels like this can be a potential footgun where a folder is included in the artifact but RAT check is ignored in `.rat-excludes`. I think we can add a CI check to prevent this. I'll track this as a separate issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
