ferhatelmas commented on code in PR #667:
URL: https://github.com/apache/iceberg-go/pull/667#discussion_r2666756060
##########
table/snapshot_producers.go:
##########
@@ -260,11 +262,12 @@ func (m *manifestMergeManager) groupBySpec(manifests
[]iceberg.ManifestFile) map
return groups
}
-func (m *manifestMergeManager) createManifest(specID int, bin
[]iceberg.ManifestFile) (iceberg.ManifestFile, error) {
+func (m *manifestMergeManager) createManifest(specID int, bin
[]iceberg.ManifestFile) (mf iceberg.ManifestFile, err error) {
wr, path, counter, err := m.snap.newManifestWriter(m.snap.spec(specID))
if err != nil {
return nil, err
}
+ defer internal.CheckedClose(wr, &err)
Review Comment:
https://github.com/apache/iceberg-go/blob/9e4a5b74ffc284f3ca5e84a15f79f6dee45afaab/manifest.go#L1124-L1126
no because it's no-op, `Close()` sets `closed` field to true (first defer)
and when it's true (second defer), it returns early
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
