dongxiao1198 commented on code in PR #490: URL: https://github.com/apache/iceberg-cpp/pull/490#discussion_r2667644909
########## src/iceberg/table_metadata.cc: ########## @@ -1077,6 +1083,79 @@ int32_t TableMetadataBuilder::Impl::ReuseOrCreateNewSchemaId( return new_schema_id; } +Status TableMetadataBuilder::Impl::SetRef(const std::string& name, Review Comment: Agree. This pr depends on the implement of SetRef and AddSnapshot, I will rebase code after https://github.com/apache/iceberg-cpp/pull/408 to avoiding conflict -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
